Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use csv module to generate csv data #1428

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Use csv module to generate csv data #1428

merged 2 commits into from
Jun 15, 2020

Conversation

ajt89
Copy link
Contributor

@ajt89 ajt89 commented Jun 15, 2020

@codecov
Copy link

codecov bot commented Jun 15, 2020 •
edited
Loading

Codecov Report

Merging #1428 into master will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
+ Coverage   80.92%   81.10%   +0.17%     
==========================================
  Files          26       26              
  Lines        2338     2344       +6     
  Branches      362      362              
==========================================
+ Hits         1892     1901       +9     
+ Misses        352      351       -1     
+ Partials       94       92       -2
Impacted Files Coverage Δ
locust/stats.py 88.78% <100.00%> (+0.02%) ⬆️
locust/web.py 91.48% <100.00%> (+0.23%) ⬆️
locust/runners.py 80.41% <0.00%> (+0.20%) ⬆️
locust/user/task.py 97.26% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228055e...494e4d9. Read the comment docs.

cyberw
cyberw reviewed Jun 15, 2020
View reviewed changes
locust/web.py Outdated Show resolved Hide resolved
@cyberw
Copy link
Collaborator

cyberw commented Jun 15, 2020

Cool stuff! I'll merge this if you fix that minor nit-pick :)

@cyberw cyberw merged commit 96cd2ca into locustio:master Jun 15, 2020
@cyberw
Copy link
Collaborator

cyberw commented Jun 15, 2020

Thanks!

@ajt89 ajt89 deleted the csv-output-fixes branch June 16, 2020 00:44
@cyberw cyberw mentioned this pull request Jun 16, 2020
Closed
@heyman heyman mentioned this pull request Aug 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyberw cyberw cyberw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajt89 @cyberw